Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin all nodes everywhere to node 14.17.1 #1973

Merged
merged 1 commit into from
Jul 1, 2021
Merged

Pin all nodes everywhere to node 14.17.1 #1973

merged 1 commit into from
Jul 1, 2021

Conversation

iamleeg
Copy link
Contributor

@iamleeg iamleeg commented Jul 1, 2021

I'm hoping that this is the final nail in the "ERR: CB() was never called!" error's coffin. I've made sure the engine version and the Docker image for each of the services is set to 14.17.1, so they should all have compatible package-lock and cache formats. The biggest change is that the data service was using node 12 in production for no observable reason, but I ran both its unit tests and the integration tests on the docker-compose stack locally and didn't find any regressions.

@codecov-commenter
Copy link

Codecov Report

Merging #1973 (813b6e1) into main (94f4a78) will decrease coverage by 20.81%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##             main    #1973       +/-   ##
===========================================
- Coverage   87.33%   66.51%   -20.82%     
===========================================
  Files          32      132      +100     
  Lines         916     4483     +3567     
  Branches      190     1179      +989     
===========================================
+ Hits          800     2982     +2182     
- Misses        116     1501     +1385     
Impacted Files Coverage Δ
...c/components/new-case-form-fields/Demographics.tsx 72.22% <0.00%> (ø)
...ion/curator-service/api/src/controllers/geocode.ts 75.00% <0.00%> (ø)
...ation/curator-service/api/src/controllers/users.ts 67.64% <0.00%> (ø)
...cation/curator-service/api/src/controllers/auth.ts 55.00% <0.00%> (ø)
...ce/ui/src/components/landing-page/PartnerLogos.tsx 100.00% <0.00%> (ø)
.../components/new-case-form-fields/TravelHistory.tsx 79.16% <0.00%> (ø)
...i/src/components/new-case-form-fields/NumCases.tsx 75.00% <0.00%> (ø)
...rification/curator-service/api/src/model/upload.ts 100.00% <0.00%> (ø)
...cation/curator-service/ui/src/components/Utils.tsx 100.00% <0.00%> (ø)
...ion/curator-service/ui/src/components/EditCase.tsx 100.00% <0.00%> (ø)
... and 90 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 94f4a78...813b6e1. Read the comment docs.

@iamleeg iamleeg merged commit c426f4d into main Jul 1, 2021
@iamleeg iamleeg deleted the pin-node-version branch July 1, 2021 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants