Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

curator/api: Encode urls POSTed to data service #1984

Merged
merged 1 commit into from
Jul 6, 2021
Merged

Conversation

abhidg
Copy link
Contributor

@abhidg abhidg commented Jul 6, 2021

No description provided.

@abhidg abhidg requested a review from iamleeg July 6, 2021 10:15
@codecov-commenter
Copy link

Codecov Report

Merging #1984 (fcaa6a1) into main (4093c5f) will increase coverage by 9.04%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1984      +/-   ##
==========================================
+ Coverage   66.51%   75.56%   +9.04%     
==========================================
  Files         132       24     -108     
  Lines        4483      929    -3554     
  Branches     1179      147    -1032     
==========================================
- Hits         2982      702    -2280     
+ Misses       1501      227    -1274     
Impacted Files Coverage Δ
...ion/curator-service/api/src/controllers/sources.ts 82.16% <100.00%> (+0.09%) ⬆️
...on/curator-service/ui/src/components/StaticMap.tsx
...c/components/landing-page/VerificationCodeForm.tsx
...cation/curator-service/ui/src/components/Users.tsx
.../src/components/new-case-form-fields/Pathogens.tsx
...ion/curator-service/ui/src/components/AppModal.tsx
...tor-service/ui/src/components/util/searchQuery.tsx
...ata-serving/data-service/src/model/transmission.ts
...or-service/ui/src/components/util/randomString.tsx
...ui/src/components/new-case-form-fields/Variant.tsx
... and 99 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4093c5f...fcaa6a1. Read the comment docs.

Copy link
Contributor

@iamleeg iamleeg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, I would have wrapped encodeURIComponent(user.email) but this works equally well.

@abhidg abhidg merged commit d833be3 into main Jul 6, 2021
@abhidg abhidg deleted the encode-email branch July 6, 2021 11:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants