-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added localstack batch and locale2e #2001
Conversation
jim-sheldon
commented
Jul 14, 2021
- Create S3 buckets
- Create Batch Job Queue
- Add email address to SES
- Curator AWS clients use localstack when using locale2e docker-compose stack
- Curator async download uses localstack when using locale2e docker-compose stack
5cc8c05
to
964825e
Compare
Codecov Report
@@ Coverage Diff @@
## main #2001 +/- ##
===========================================
- Coverage 81.40% 62.28% -19.13%
===========================================
Files 56 96 +40
Lines 1845 3516 +1671
Branches 337 987 +650
===========================================
+ Hits 1502 2190 +688
- Misses 343 1326 +983
Continue to review full report at Codecov.
|
counter += 1 | ||
print("Waiting for localstack") | ||
sleep(5) | ||
raise Exception("Localstack not available") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When I try running dev/run_full_stack.sh
locally I hit this exception, is there any setup I need to do? I've set LOCALSTACK_API_KEY
in dev/.env
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I suspect a timing issue. I increased the number of attempts to 20.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can't reproduce this, but I got this error message:
Error response from daemon: invalid mount config for type "bind": bind source path does not exist: /tmp/localstack
Creating /tmp/localstack fixed this
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Creating /tmp/localstack fixed this
Should that ideally go in the host's /tmp
or the docker image's /tmp
? Either way, it needs to be scripted.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Strange, I didn't run into that. FWIW /tmp
exists in the docker image, but I'm not using it for anything--the volume declared in the compose file was a default--so I removed it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I still see that the timeout exception is raised before the localstack has launched:
setup-localstack_1 | Waiting for localstack
setup-localstack_1 | Traceback (most recent call last):
setup-localstack_1 | File "./setup_localstack.py", line 177, in <module>
setup-localstack_1 | wait_for_localstack()
setup-localstack_1 | File "./setup_localstack.py", line 172, in wait_for_localstack
setup-localstack_1 | raise Exception("Localstack not available")
setup-localstack_1 | Exception: Localstack not available
setup-localstack_1 exited with code 1
localstack_1 | Waiting for all LocalStack services to be ready
localstack_1 | 2021-07-16T08:25:19:INFO:botocore.credentials: Found credentials in environment variables.
localstack_1 | Waiting for all LocalStack services to be ready
localstack_1 | Ready.
localstack_1 | 2021-07-16 08:25:24,808:API: 127.0.0.1 - - [16/Jul/2021 08:25:24] "GET / HTTP/1.1" 200 -
localstack_1 | 2021-07-16T08:25:24:INFO:localstack.utils.analytics.profiler: Execution of "start_api_services" took 12558.80ms
Could the setup image use wait-for-it.sh
and run when the localstack service is finally accepting connections?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Couple of small changes, looks good otherwise!
88f9ebf
to
5cf4f93
Compare
5cf4f93
to
9f22d24
Compare
I see the same test failure in FF on a different PR. I'll try to fix and get a commit for you to cherry-pick. |
I'm not proud but df56a02 works. |
of pausing after clicking the button before checking for the menu item