Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added popup on small devices #2501

Merged
merged 4 commits into from
Mar 1, 2022
Merged

Conversation

sergioloporto
Copy link
Contributor

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Feb 10, 2022

Codecov Report

Merging #2501 (08440e1) into main (a96dc69) will decrease coverage by 29.45%.
The diff coverage is 90.90%.

Impacted file tree graph

@@             Coverage Diff             @@
##             main    #2501       +/-   ##
===========================================
- Coverage   88.89%   59.43%   -29.46%     
===========================================
  Files          34       82       +48     
  Lines        1171     3030     +1859     
  Branches      273      996      +723     
===========================================
+ Hits         1041     1801      +760     
- Misses        130     1229     +1099     
Impacted Files Coverage Δ
...tion/curator-service/ui/src/components/App/App.tsx 86.30% <ø> (ø)
...ator-service/ui/src/components/DataGuideDialog.tsx 100.00% <ø> (ø)
...or-service/ui/src/components/PopupSmallScreens.tsx 90.90% <90.90%> (ø)
data-serving/data-service/src/model/vaccine.ts
data-serving/data-service/src/model/date.ts
data-serving/data-service/src/model/travel.ts
data-serving/data-service/src/util/search.ts
data-serving/data-service/src/model/source.ts
data-serving/data-service/src/model/case.ts
data-serving/data-service/src/model/event.ts
... and 108 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b30b11f...08440e1. Read the comment docs.

@abhidg abhidg changed the title added popup Added popup on small devices Mar 1, 2022
Copy link
Contributor

@abhidg abhidg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@abhidg abhidg merged commit 0872ba3 into main Mar 1, 2022
@abhidg abhidg deleted the 2423-popup-small-screens-data-site branch March 1, 2022 09:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants