Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default sorting by confirmation date #2098 #2540

Merged
merged 12 commits into from
Mar 9, 2022
Merged

Conversation

maciej-zarzeczny
Copy link
Contributor

Setup default sorting by confirmationDate in Line list table and added needed indexes to MongoDB

@maciej-zarzeczny maciej-zarzeczny self-assigned this Feb 22, 2022
@codecov-commenter
Copy link

codecov-commenter commented Feb 22, 2022

Codecov Report

Merging #2540 (018dfb7) into main (bb83347) will increase coverage by 6.49%.
The diff coverage is 96.42%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2540      +/-   ##
==========================================
+ Coverage   61.24%   67.73%   +6.49%     
==========================================
  Files         106      115       +9     
  Lines        4177     4215      +38     
  Branches     1200     1275      +75     
==========================================
+ Hits         2558     2855     +297     
+ Misses       1619     1360     -259     
Impacted Files Coverage Δ
data-serving/data-service/src/util/case.ts 91.01% <96.29%> (ø)
data-serving/data-service/src/index.ts 95.71% <100.00%> (ø)
...tion/curator-service/ui/src/components/App/App.tsx 86.30% <100.00%> (ø)
...urator-service/ui/src/components/LinelistTable.tsx 52.56% <100.00%> (ø)
...rification/curator-service/api/src/model/parser.ts
verification/curator-service/api/src/index.ts
...tion/curator-service/api/src/util/assert-string.ts
...ion/curator-service/api/src/controllers/geocode.ts
...rator-service/api/src/clients/aws-events-client.ts
...ation/curator-service/api/src/controllers/users.ts
... and 53 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bb83347...018dfb7. Read the comment docs.

@abhidg abhidg changed the title 2098 - default sorting by confirmation date Default sorting by confirmation date #2098 Feb 24, 2022
Copy link
Contributor

@abhidg abhidg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@abhidg abhidg merged commit df2f583 into main Mar 9, 2022
@abhidg abhidg deleted the 2098-sort-by-confirmation-date branch March 9, 2022 10:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants