Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add fields required for acknowledgements page #2499 #2547

Merged
merged 5 commits into from
Feb 24, 2022

Conversation

iamleeg
Copy link
Contributor

@iamleeg iamleeg commented Feb 24, 2022

Add the extra fields that can be used to generate the acknowledgements page for #2499. I noticed that the "source name" wasn't being used in a very informative way so I've added another name field that should be used to identify the data provider.

@codecov-commenter
Copy link

codecov-commenter commented Feb 24, 2022

Codecov Report

Merging #2547 (410b8c9) into main (bb83347) will decrease coverage by 0.10%.
The diff coverage is 28.57%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2547      +/-   ##
==========================================
- Coverage   61.24%   61.13%   -0.11%     
==========================================
  Files         106      106              
  Lines        4177     4191      +14     
  Branches     1200     1210      +10     
==========================================
+ Hits         2558     2562       +4     
- Misses       1619     1629      +10     
Impacted Files Coverage Δ
...rification/curator-service/api/src/model/origin.ts 100.00% <ø> (ø)
...-service/ui/src/components/AutomatedSourceForm.tsx 43.75% <ø> (ø)
...curator-service/ui/src/components/BulkCaseForm.tsx 10.21% <ø> (ø)
...ion/curator-service/ui/src/components/CaseForm.tsx 14.53% <ø> (ø)
...ce/ui/src/components/common-form-fields/Source.tsx 46.66% <0.00%> (-3.34%) ⬇️
.../curator-service/ui/src/components/SourceTable.tsx 71.68% <50.00%> (-1.10%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e6470d2...410b8c9. Read the comment docs.

@iamleeg iamleeg merged commit bcbfdfd into main Feb 24, 2022
@iamleeg iamleeg deleted the 2185_source_info_in_source_data branch February 24, 2022 15:05
@abhidg abhidg changed the title 2185 source info in source data Add fields required for acknowledgements page #2499 Feb 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants