Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

parsing(hong_kong): Fix ValueError and set country code to HK #2565

Merged
merged 2 commits into from
Mar 1, 2022
Merged

parsing(hong_kong): Fix ValueError and set country code to HK #2565

merged 2 commits into from
Mar 1, 2022

Conversation

abhidg
Copy link
Contributor

@abhidg abhidg commented Mar 1, 2022

  • parsing(hong_kong): return None in age when ValueError
  • parsing(hong_kong): set country code to HK

@abhidg abhidg changed the title update hk parser parsing(hong_kong): Fix ValueError and set country code to HK Mar 1, 2022
@abhidg
parsing(hong_kong): set country code to HK
0b0172e 
We are using ISO codes now which are suitable for both
countries and constituent territories.
@abhidg abhidg merged commit 6a7751b into main Mar 1, 2022
@abhidg abhidg deleted the update-hk-parser branch March 1, 2022 17:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jim-sheldon jim-sheldon jim-sheldon approved these changes

@iamleeg iamleeg Awaiting requested review from iamleeg

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@abhidg @jim-sheldon