Remove notes field, fixes #2673 #2680
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abhidg
force-pushed
the
2673-remove-notes
branch
3 times, most recently
from
d9e6e98
to
cb3d370
Compare
abhidg
force-pushed
the
2673-remove-notes
branch
from
cb3d370
to
3ccce55
Compare
abhidg
force-pushed
the
2673-remove-notes
branch
2 times, most recently
from
789f79f
to
58d15f9
Compare
Remove bit of test that checks whether the first hit of the text search term is in highlighted class, as it actually gets a MuiChip-label pill.
abhidg
force-pushed
the
2673-remove-notes
branch
from
58d15f9
to
2201142
Compare
iamleeg
approved these changes
Apr 29, 2022
Comment on lines
80
to
+81
| delete dto.restrictedNotes; | ||
| delete dto.notes; |
There was a problem hiding this comment.
Maybe this is a "not yet" task but we could migrate restrictedNotes back over to notes, as all notes are now restricted. Then we would be able to build a single approach to exposing notes later.
| ["_id","caseReference.additionalSources","caseReference.sourceEntryId","caseReference.sourceId","caseReference.sourceUrl","caseReference.uploadIds","caseReference.verificationStatus","demographics.ageRange.end","demographics.ageRange.start","demographics.ethnicity","demographics.gender","demographics.nationalities","demographics.occupation","events","location.administrativeAreaLevel1","location.administrativeAreaLevel2","location.administrativeAreaLevel3","location.country","location.geoResolution","location.geometry.latitude","location.geometry.longitude","location.name","location.place","location.query","pathogens","preexistingConditions.hasPreexistingConditions","preexistingConditions.values","revisionMetadata.creationMetadata.curator","revisionMetadata.creationMetadata.date","revisionMetadata.creationMetadata.notes","revisionMetadata.editMetadata.curator","revisionMetadata.editMetadata.date","revisionMetadata.editMetadata.notes","revisionMetadata.revisionNumber", "SGTF", "symptoms.status","symptoms.values","transmission.linkedCaseIds","transmission.places","transmission.routes","travelHistory.travel.dateRange.end","travelHistory.travel.dateRange.start","travelHistory.travel.location.name","travelHistory.travel.methods","travelHistory.travel.purpose","travelHistory.traveledPrior30Days","vaccines.0.name","vaccines.0.batch","vaccines.0.date","vaccines.0.sideEffects","vaccines.1.name","vaccines.1.batch","vaccines.1.date","vaccines.1.sideEffects","vaccines.2.name","vaccines.2.batch","vaccines.2.date","vaccines.2.sideEffects","vaccines.3.name","vaccines.3.batch","vaccines.3.date","vaccines.3.sideEffects",""] |
There was a problem hiding this comment.
this would be easier to diff if we put each element on its own line :)
| @@ -200,41 +207,21 @@ describe('GET', () => { | |||
| .expect(200); | |||
| expect(res.body.cases).toHaveLength(1); | |||
| }); | |||
| it('should query results', async () => { | |||
There was a problem hiding this comment.
Is there any text that the query should work over instead of notes, or is there any free-text search facility at all in the platform now? If not we can also drop the text index, which will speed up ingestion and save 13.5G in the prod cluster (the main collection is only 10.1G!)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes the notes field in the UI, API and exports. It doesn't actually delete the notes field in the database yet, which we can do at a later point, or create a separate access control to only give access to notes.