Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: fix syntax error in workflow_dispatch #2689

Merged
merged 1 commit into from
Apr 29, 2022
Merged

Conversation

abhidg
Copy link
Contributor

@abhidg abhidg commented Apr 29, 2022

workflow_dispatch does not take paths or branches

@jim-sheldon
Copy link
Collaborator

Is the resulting YAML valid? It looks like declaring a key without a value.
If not, we should be able to use {}.

Out of curiosity, where did you find that workflow_dispatch does not take paths or branches? I can't find it in the Github documentation, and I do see one post about it that links to code that has branches removed in a later commit.

- '.github/workflows/geocoding-service-python.yml'
- 'geocoding/location-service/**'
workflow_dispatch:
paths:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

delete just this block and leave the above config intact?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo! thanks

@abhidg
Copy link
Contributor Author

abhidg commented Apr 29, 2022

Is the resulting YAML valid? It looks like declaring a key without a value. If not, we should be able to use {}.

GitHub Actions seems to be fine with it, as is pyyaml (yaml.safe_load("a:\n b:\n c:\n")), which keeps the value at None.

Out of curiosity, where did you find that workflow_dispatch does not take paths or branches? I can't find it in the Github documentation, and I do see one post about it that links to code that has branches removed in a later commit.

Build failures, such as https://github.com/globaldothealth/list/actions/runs/2244984521

workflow_dispatch does not take paths or branches
@abhidg abhidg merged commit c12dd70 into main Apr 29, 2022
@abhidg abhidg deleted the ci-fix-workflow-dispatch branch April 29, 2022 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants