Fix data-service CI failures #2691
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iamleeg
reviewed
May 4, 2022
| @@ -1099,7 +1118,9 @@ export const casesMatchingSearchQuery = (opts: { | |||
| }): any => { | |||
| // set data limit to 10K by default | |||
| const countLimit = opts.limit ? opts.limit : 10000; | |||
| console.log(`Search query: ${opts.searchQuery}`); | |||
iamleeg
reviewed
May 4, 2022
| @@ -779,13 +786,15 @@ describe('POST', () => { | |||
| const newCaseInDb = await Case.findOne({ | |||
| 'revisionMetadata.revisionNumber': 0, | |||
| }); | |||
| console.log(newCaseInDb); | |||
iamleeg
approved these changes
May 4, 2022
Data service CI was failing due to the notes removal change. After this, setting the 'notes' field of a case document doesn't actually result in a updated case, as the notes field is deleted by controllers, and it is not returned from the data service APIs. To simulate an updated document, this adds a pathogen key to a case.
abhidg
force-pushed
the
fix-data-service-ci-notes-removal
branch
from
1f49d9b
to
b2631d8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Data service CI was failing due to the notes removal change. After this,
setting the 'notes' field of a case document doesn't actually result in
a updated case, as the notes field is deleted by controllers, and it is
not returned from the data service APIs.
To simulate an updated document, this adds a pathogen key to a case.