Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove source entry IDs from exports and downloads #2696

Merged
merged 1 commit into from
May 17, 2022

Conversation

jim-sheldon
Copy link
Collaborator

No description provided.

@abhidg
Copy link
Contributor

abhidg commented May 12, 2022

Should probably use a salt - otherwise it is easy to compare hashes against the original data source.

@jim-sheldon jim-sheldon force-pushed the 2671-hash-ingested-source-entry-ids branch 2 times, most recently from 925ab70 to 378a824 Compare May 13, 2022 19:27
@codecov-commenter
Copy link

codecov-commenter commented May 17, 2022

Codecov Report

Merging #2696 (eae79a0) into main (985e8f4) will increase coverage by 1.15%.
The diff coverage is 92.00%.

@@            Coverage Diff             @@
##             main    #2696      +/-   ##
==========================================
+ Coverage   65.72%   66.87%   +1.15%     
==========================================
  Files         146      129      -17     
  Lines        5628     4450    -1178     
  Branches     1501     1315     -186     
==========================================
- Hits         3699     2976     -723     
+ Misses       1929     1474     -455     
Impacted Files Coverage Δ
...ion/curator-service/ui/src/components/ViewCase.tsx 79.87% <ø> (-0.13%) ⬇️
data-serving/data-service/src/controllers/case.ts 82.63% <85.18%> (+0.31%) ⬆️
data-serving/data-service/src/model/case.ts 98.36% <100.00%> (+0.05%) ⬆️
...ata-serving/data-service/src/model/demographics.ts 100.00% <100.00%> (ø)
data-serving/data-service/src/util/case.ts 91.07% <100.00%> (+0.06%) ⬆️
...-service/ui/src/components/FiltersDialog/index.tsx 72.09% <0.00%> (-0.78%) ⬇️
...erification/curator-service/api/src/model/token.ts
...fication/curator-service/api/src/model/database.ts
...ation/curator-service/api/src/controllers/users.ts
...ion/curator-service/api/src/controllers/uploads.ts
... and 14 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 997e260...eae79a0. Read the comment docs.

@jim-sheldon jim-sheldon force-pushed the 2671-hash-ingested-source-entry-ids branch from eae79a0 to c5be19b Compare May 17, 2022 15:53
@jim-sheldon jim-sheldon changed the title Hashing source entry IDs Remove source entry IDs from exports and downloads May 17, 2022
@jim-sheldon jim-sheldon marked this pull request as ready for review May 17, 2022 16:28
Copy link
Contributor

@abhidg abhidg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@jim-sheldon jim-sheldon merged commit 4a0e9c9 into main May 17, 2022
@jim-sheldon jim-sheldon deleted the 2671-hash-ingested-source-entry-ids branch May 17, 2022 20:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants