2672 forget users #2709
Merged
2672 forget users #2709
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
At some point, the Google OAuth provider has changed from not returning a name at all (i.e. undefined) to returning null for a name. Because this can be stored in the database, it produces 500 errors when viewing the user table (even though the curator UI could correctly handle any falsey value for the name). This change documents that the name is nullable, allowing the null to be passed through and correctly interpreted by the UI.
Codecov Report
@@ Coverage Diff @@
## main #2709 +/- ##
=======================================
Coverage 62.26% 62.26%
=======================================
Files 17 17
Lines 1219 1219
Branches 190 190
=======================================
Hits 759 759
Misses 460 460 Continue to review full report at Codecov.
|
abhidg
approved these changes
May 25, 2022
jim-sheldon
approved these changes
May 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here is the UI change that allows an admin user to delete any user. There is no bulk delete action: you must choose one user, press two buttons (bring up the menu, then press delete), then confirm in a dialog box. Deleting your own account is possible, and on doing so you'll be redirected to the homepage (where you find you are logged out).