Audit fix #2731
Merged
Audit fix #2731
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I can't explain why, but before preparing this commit I couldn't npm install in the data-service _at all_ due to conflicting peer deps. I resolved that in this change, but then found that there were a lot of failing tests in the data service. I don't know when they were introduced so I can't account for them, but it seems that OpenAPI validation has changed from "no schema === any response" to "no schema === empty response". For those responses where the presence of a body was causing a test failure, I have introduced a permissive "any JSON response" schema.
Codecov Report
@@ Coverage Diff @@
## main #2731 +/- ##
==========================================
+ Coverage 57.72% 65.90% +8.17%
==========================================
Files 94 147 +53
Lines 3229 5722 +2493
Branches 1030 1512 +482
==========================================
+ Hits 1864 3771 +1907
- Misses 1365 1951 +586
Continue to review full report at Codecov.
|
abhidg
approved these changes
Jun 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.