Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

2714 new data service #2732

Merged
merged 23 commits into from
Jun 21, 2022
Merged

2714 new data service #2732

merged 23 commits into from
Jun 21, 2022

Conversation

iamleeg
Copy link
Contributor

@iamleeg iamleeg commented Jun 17, 2022 •
edited
Loading

Really early days but here is an end-to-end implementation of one API route to give a sense of the design and get early correction. Some notes:

  • there is exactly one data store at the moment (mongodb), but the service is designed to be flexible and to configure store at launch time
  • the data model has a base class for the day zero schema and a configuration point where additional fields can be supplied: I don't use that yet
  • no OpenAPI docs/conformance yet

@iamleeg iamleeg marked this pull request as ready for review June 20, 2022 12:18
abhidg
abhidg reviewed Jun 20, 2022
View reviewed changes
Copy link
Contributor

@abhidg abhidg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, other than a typo. Should we use date instead of datetime? We don't have any time-related data in the current schema

.github/workflows/reusable-data-service-ci.yml Outdated Show resolved Hide resolved
data-serving/reusable-data-service/reusable_data_service/model/case.py Outdated Show resolved Hide resolved
data-serving/reusable-data-service/reusable_data_service/model/case.py Outdated Show resolved Hide resolved
data-serving/reusable-data-service/tests/test_case_end_to_end.py Outdated Show resolved Hide resolved
data-serving/reusable-data-service/tests/test_case_end_to_end.py Outdated Show resolved Hide resolved
@iamleeg iamleeg requested a review from abhidg June 20, 2022 15:19
@iamleeg
Update test to store a BSON confirmation date; fix case model to dese…
bd60467 
…rialise such dates #2714

I chose not to handle this in the mongo_store because it would have been (cognitively and computationally) inefficient: it would mean dumping the BSON, loading the JSON, patching it, dumping that, then loading in the model. Nein, danke!
@iamleeg iamleeg merged commit 7db857d into main Jun 21, 2022
@iamleeg iamleeg deleted the 2714_new_data_service branch June 21, 2022 10:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abhidg abhidg abhidg left review comments

@jim-sheldon jim-sheldon Awaiting requested review from jim-sheldon

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@iamleeg @abhidg