Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump node to 16 LTS #2741

Merged
merged 1 commit into from
Oct 19, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/curator-api-node.yml
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ jobs:
- name: Use Node.js
uses: actions/setup-node@v3
with:
node-version: "12.x"
node-version: "16.x"
- name: Build and test
run: |
npm ci
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/curator-ui-node.yml
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ jobs:
- name: Use Node.js
uses: actions/setup-node@v3
with:
node-version: "12.x"
node-version: "16.x"
- name: Build and test
run: |
git config --global url."https://github.com/".insteadOf git@github.com:
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/data-service-node.yml
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ jobs:
- name: Use Node.js
uses: actions/setup-node@v3
with:
node-version: "12.x"
node-version: "16.x"
- name: Build and test
run: |
npm ci
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/update-dev-curator-db-schema.yml
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ jobs:
- name: Set up Node.js
uses: actions/setup-node@v3
with:
node-version: "12.x"
node-version: "16.x"

- name: Migrate dev database
env:
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/update-prod-curator-db-schema.yml
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ jobs:
- name: Set up Node.js
uses: actions/setup-node@v3
with:
node-version: "12.x"
node-version: "16.x"

- name: Migrate prod database
env:
Expand Down
6 changes: 3 additions & 3 deletions data-serving/data-service/Dockerfile
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
# Docker file for data service.
# Follows multi-staged build where "dev" can be used for development
# and "prod" follows security best-practices and uses a trimmed down image.
FROM node:14.17.1 as dev
FROM node:16.18.0 as dev

# Create app directory
WORKDIR /usr/src/app/data-serving/data-service
Expand Down Expand Up @@ -35,7 +35,7 @@ EXPOSE 3000
CMD [ "npm", "start" ]

# Multi-staged build, we don't need a full node image to run the app.
FROM node:14.17.1-alpine as prod
FROM node:16.18.0-alpine as prod

# No need to run as root.
USER node
Expand All @@ -52,4 +52,4 @@ COPY --from=dev /usr/src/app/data-serving/data-service/dist ./dist

# Start service, do not use npm start instead invoke node directly
# to avoid wrapping the process uselessly and correctly catch SIGTERM and SIGINT.
CMD [ "node", "dist/server.js" ]
CMD [ "node", "dist/server.js" ]
2 changes: 1 addition & 1 deletion data-serving/data-service/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -97,6 +97,6 @@
]
},
"engines": {
"node": "14.17.1"
"node": "16.18.0"
}
}
4 changes: 2 additions & 2 deletions verification/curator-service/Dockerfile
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
# This dockerfile builds the curator API service and its UI in a single container.
# The UI is served as a static resource from the curator API service express server.
# Security best practices are followed and a trimmed down image is used for production serving.
FROM node:14.17.6 as builder
FROM node:16.18.0 as builder

# Build the curator service.
WORKDIR /usr/src/app/verification/curator-service/api
Expand Down Expand Up @@ -47,7 +47,7 @@ RUN npm run build


# Multi-staged build, use a trimmed down version of node for prod.
FROM node:14.17.6 as prod
FROM node:16.18.0 as prod

# No need to run as root.
USER node
Expand Down
4 changes: 2 additions & 2 deletions verification/curator-service/api/Dockerfile
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
# Dev docker file for curator service.
FROM node:16.14.2
FROM node:16.18.0

# set the version (this should be set from outside)
ARG CURATOR_VERSION
Expand All @@ -23,4 +23,4 @@ RUN npm run build
# Expose service on port 3001.
EXPOSE 3001
# Start the service.
CMD [ "npm", "start" ]
CMD [ "npm", "start" ]
2 changes: 1 addition & 1 deletion verification/curator-service/api/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -110,6 +110,6 @@
]
},
"engines": {
"node": "16.14.2"
"node": "16.18.0"
}
}
4 changes: 2 additions & 2 deletions verification/curator-service/ui/Dockerfile
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
# Dev docker file for curator UI.
FROM node:14.17.1
FROM node:16.18.0

WORKDIR /usr/src/app/verification/curator-service/ui
# Install app dependencies
Expand All @@ -16,4 +16,4 @@ COPY verification/curator-service/ui/. .
# Bundle common files
COPY common/* ../../../common/
# Start the service.
CMD [ "npm", "start" ]
CMD [ "npm", "start" ]
2 changes: 1 addition & 1 deletion verification/curator-service/ui/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -127,6 +127,6 @@
]
},
"engines": {
"node": "14.17.1"
"node": "16.18.0"
}
}