#2714 batch status change #2744
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abhidg
reviewed
Jul 7, 2022
data-serving/reusable-data-service/data_service/model/case_exclusion_metadata.py
Show resolved
Hide resolved
|
|
||
| def to_csv(self) -> str: | ||
| """Generate a row in a CSV file representing myself.""" | ||
| return self.delimiter_separated_values(",") |
There was a problem hiding this comment.
Does this handle commas in values?
There was a problem hiding this comment.
Uh, no, not yet…that's a good case to add.
There was a problem hiding this comment.
The challenge is though that there's nowhere a comma can appear in the model (yet) such that it will appear in the CSV file. We don't want a free-form notes field for privacy reasons, and exclusion metadata is not included in the CSV download (as it isn't included in the data-service download either). So while there's a reason to do this, there isn't currently a situation where it can occur. I suggest merging this PR and revisiting it when the DayZeroSchema or custom schema includes a field that can have a comma in.
|
Sounds good to me!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ready for review. My problem was not deserialising a model object correctly so I've introduced a superclass to make it more obvious what custom serialisation/deserialisation code a particular document type supplies.