Fix KeyError parsing for Cuba #2778
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Does not address source data split
abhidg
reviewed
Jul 21, 2022
| for centre in json_data[centre_type]: | ||
| hospital_map[centre] = json_data[centre_type][centre]['nombre'] + \ | ||
| ", " + json_data[centre_type][centre]['provincia'] | ||
| except: |
There was a problem hiding this comment.
use except KeyError here - in case some other exception is raised. Also good to use logging.info to print a message saying that key was not found
There was a problem hiding this comment.
New commit [6c96b56] deals with this.
abhidg
reviewed
Jul 21, 2022
| if schema_version != 7: | ||
| logger.warning( | ||
| f'Schema version has been updated from 7 to {schema_version}') | ||
| try: |
There was a problem hiding this comment.
Was schema-version removed? A change in schema-version should break the script, as we might not be capturing the correct fields.
There was a problem hiding this comment.
schema-version was removed. There is no mention of schema-version in covid19-cuba-1.json.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The split of the data into covid19-cuba-{1,2,...}.json, as described in issue #2233 is not addressed by the changes here. Any of the covid19-cuba-{1,2,...}.json files can be parsed by the changes, as well as covid19-cuba-old.json.