#2714 fields with associated free other value #2786
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The free text is stored in an associated string field
jim-sheldon
reviewed
Jul 27, 2022
| @@ -60,14 +60,21 @@ def from_dict(cls, dictionary): | |||
| def python_type(self) -> type: | |||
| return self.model_type(self.type) | |||
|
|
|||
| def dataclasses_tuple(self) -> (str, type, dataclasses.Field): | |||
| def dataclasses_tuples(self): | |||
There was a problem hiding this comment.
-> (str, type, dataclasses.Field)?
There was a problem hiding this comment.
should be -> List[(str, type, dataclasses.Field)] but I couldn't get the type checker in Python 3.10 to accept that. Maybe a bug in the type checker? Anyway it wouldn't load the module so I removed the type hint.
There was a problem hiding this comment.
list[tuple[str, type, dataclasses.Field]] should work (from typing import List, Tuple not required anymore)
jim-sheldon
approved these changes
Jul 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If one of the enumerated values in a field is 'other', then you get (at no additional cost to the purchaser) a string field named fieldName_other where we can store the free text value.