Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#2697 captcha to feedback from submission #2792

Merged
merged 18 commits into from
Sep 1, 2022
Merged

#2697 captcha to feedback from submission #2792

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
18 commits
Select commit Hold shift + click to select a range
176df83
opening and closing modal without functionality
Jul 14, 2022
43d1308
work in progress
Jul 15, 2022
1739126
sending and reciving endpoint information
Jul 15, 2022
bc4783b
pre google captcha
Jul 18, 2022
6ab6e13
pre secret stored captcha
Jul 20, 2022
fd4cdc0
backend recaptcha secret key applied
Jul 26, 2022
b247406
work in progress
Aug 8, 2022
203e6e9
mid task merge
Aug 8, 2022
641a211
added captcha for signin, signup; yaml documentation for /feedback, r…
Aug 8, 2022
0da6aa8
refactoring after CR
Aug 9, 2022
73d3499
fix for modal errors and feedback alert
Aug 10, 2022
22457fc
test fix
Aug 10, 2022
d512dce
CR fix
Aug 10, 2022
8bbdb22
Merge branch 'main' into 2697-captcha-to-feedback-from-submission
OskarKocjan Aug 30, 2022
ce33e39
test setup
Aug 31, 2022
28ad0da
fix 1
Aug 31, 2022
2c03455
test fix
Aug 31, 2022
01cdc65
CR fix number of clicking on btn in test
Sep 1, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
3 changes: 0 additions & 3 deletions verification/curator-service/api/src/controllers/auth.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,6 @@ import {
resetPasswordWithTokenLimiter,
} from '../util/single-window-rate-limiters';


// Global variable for newsletter acceptance
let isNewsletterAccepted: boolean;

Expand Down Expand Up @@ -223,7 +222,6 @@ export class AuthController {
"Unfortunately, you didn't pass the captcha. Please, try again later.",
});


passport.authenticate(
'register',
(error: Error, user: IUser, info: any) => {
Expand Down Expand Up @@ -261,7 +259,6 @@ export class AuthController {
"Unfortunately, you didn't pass the captcha. Please, try again later.",
});


passport.authenticate(
'login',
(
Expand Down
1 change: 0 additions & 1 deletion verification/curator-service/ui/cypress/integration/components/AcknowledgmentsPage.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,6 @@ describe('<AcknowledgmentsPage />', function () {
response: 'fixture:acknowledgment_data.json',
delay: 3000,
}).as('fetchSources');

cy.visit('/data-acknowledgments');
cy.contains(/Data Acknowledgments/i);

Expand Down
8 changes: 6 additions & 2 deletions verification/curator-service/ui/cypress/integration/components/LandingPage.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -218,7 +218,9 @@ describe('LandingPage', function () {
cy.get('#password').type('tT$5aaaaak');
cy.get('#passwordConfirmation').type('tT$5aaaaak');
cy.get('#isAgreementChecked').check();
for (let i = 0; i < 5; i++) {
for (let i = 0; i < 7; i++) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why is the Sign-in button being clicked so many times?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is clicked so many times to trigger the login/register limiter that will be used after 4 unsuccessful attempts. I will change the number of clicks to the previous commit which is 5 times.

// eslint-disable-next-line cypress/no-unnecessary-waiting
cy.wait(1500);
cy.get('button[data-testid="sign-up-button"]').click();
}
cy.contains(
Expand All @@ -228,7 +230,9 @@ describe('LandingPage', function () {
cy.contains('Sign in!').click();
cy.get('#email').type('test@example.com');
cy.get('#password').type('test');
for (let i = 0; i < 5; i++) {
for (let i = 0; i < 7; i++) {
// eslint-disable-next-line cypress/no-unnecessary-waiting
cy.wait(1500);
cy.get('button[data-testid="sign-in-button"]').click();
}
cy.contains(/Too many failed login attempts, please try again later/i);
Expand Down
28 changes: 14 additions & 14 deletions verification/curator-service/ui/cypress/integration/components/NewCaseForm.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ describe('New case form', function () {
});
cy.addSource('Test source', 'www.example.com');

cy.visit('/')
cy.visit('/');
cy.visit('/cases/new');
cy.contains('Create new COVID-19 line list case');
cy.get('div[data-testid="caseReference"]').type('www.example.com');
Expand Down Expand Up @@ -51,7 +51,7 @@ describe('New case form', function () {
geoResolution: 'Country',
});

cy.visit('/')
cy.visit('/');
cy.visit('/cases/new');
cy.contains('Create new COVID-19 line list case');
cy.get('div[data-testid="caseReference"]').type('www.new-source.com');
Expand All @@ -74,7 +74,7 @@ describe('New case form', function () {
cy.contains('France');
cy.contains('2020-01-01');

cy.visit('/')
cy.visit('/');
cy.visit('/sources');
cy.contains('www.new-source.com');
cy.contains('New source');
Expand All @@ -90,7 +90,7 @@ describe('New case form', function () {
});
cy.addSource('Test source', 'www.example.com');

cy.visit('/')
cy.visit('/');
cy.visit('/cases/new');
cy.contains('Create new COVID-19 line list case');
cy.get('div[data-testid="caseReference"]').type('www.example.com');
Expand All @@ -111,7 +111,7 @@ describe('New case form', function () {
});

it('Can submit events without dates', function () {
cy.visit('/')
cy.visit('/');
cy.visit('/cases');
cy.contains('No records to display');
cy.seedLocation({
Expand All @@ -122,7 +122,7 @@ describe('New case form', function () {
});
cy.addSource('Test source', 'www.example.com');

cy.visit('/')
cy.visit('/');
cy.visit('/cases/new');
cy.get('div[data-testid="caseReference"]').type('www.example.com');
cy.contains('li', 'www.example.com').click();
Expand Down Expand Up @@ -164,7 +164,7 @@ describe('New case form', function () {
});
cy.addSource('Test source', 'www.example.com');

cy.visit('/')
cy.visit('/');
cy.visit('/cases/new');
cy.contains('Create new COVID-19 line list case');
cy.get('div[data-testid="caseReference"]').type('www.example.com');
Expand Down Expand Up @@ -246,7 +246,7 @@ describe('New case form', function () {
symptoms: ['fever', 'cough'],
});

cy.visit('/')
cy.visit('/');
cy.visit('/cases/new');
cy.contains('Create new COVID-19 line list case');
cy.get('div[data-testid="caseReference"]').type('www.example.com');
Expand Down Expand Up @@ -301,11 +301,11 @@ describe('New case form', function () {
geoResolution: 'Country',
});
cy.addSource('Test source', 'www.example.com');
cy.visit('/')
cy.visit('/');
cy.visit('/cases');
cy.contains('No records to display');

cy.visit('/')
cy.visit('/');
cy.visit('/cases/new');
cy.get('div[data-testid="caseReference"]').type('www.example.com');
cy.contains('li', 'www.example.com').click();
Expand All @@ -330,7 +330,7 @@ describe('New case form', function () {
});

it('Can change source URL without changing source name', function () {
cy.visit('/')
cy.visit('/');
cy.visit('/cases/new');

cy.get('div[data-testid="caseReference"]').type('www.example.com');
Expand All @@ -345,14 +345,14 @@ describe('New case form', function () {
});

it('Check for required fields', function () {
cy.visit('/')
cy.visit('/');
cy.visit('/cases/new');

cy.get('p:contains("Required")').should('have.length', 3);
});

it('Shows checkbox on field completion', function () {
cy.visit('/')
cy.visit('/');
cy.visit('/cases/new');
cy.get('svg[data-testid="check-icon"]').should('not.exist');
cy.get('div[data-testid="gender"]').click();
Expand All @@ -361,7 +361,7 @@ describe('New case form', function () {
});

it('Shows error icon on field submission error', function () {
cy.visit('/')
cy.visit('/');
cy.visit('/cases/new');
cy.get('svg[data-testid="error-icon"]').should('not.exist');
cy.get('svg[data-testid="check-icon"]').should('not.exist');
Expand Down
3 changes: 2 additions & 1 deletion verification/curator-service/ui/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,8 @@
"cypress-open": "cypress open",
"cypress-run": "cypress run",
"cypress-run-ff": "cypress run --browser firefox",
"cypress-run-edge": "cypress run --browser edge"
"cypress-run-edge": "cypress run --browser edge",
"cypress-run-chrome": "cypress run --headless --browser chrome"
},
"eslintConfig": {
"extends": "react-app"
Expand Down
3 changes: 0 additions & 3 deletions verification/curator-service/ui/src/components/FeedbackEmailDialog/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,9 +92,6 @@ const FeedbackEmailDialog = ({
},
});

// -------------------
// isOpen = true;
// -------------------
return (
<>
<Dialog
Expand Down
4 changes: 3 additions & 1 deletion verification/curator-service/ui/src/components/landing-page/SignInForm.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,9 @@ interface SignInFormProps {
setRegistrationScreenOn: (active: boolean) => void;
}

const RECAPTCHA_SITE_KEY = process.env.RECAPTCHA_SITE_KEY as string;
const RECAPTCHA_SITE_KEY = window.Cypress
? '6LeIxAcTAAAAAJcZVRqyHh71UMIEGNQ_MXjiZKhI'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this supposed to be secret? not sure

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your feedback! That's a great question. It is a ReCaptchas site-key for testing purposes which is available for all developers: https://developers.google.com/recaptcha/docs/faq#id-like-to-run-automated-tests-with-recaptcha.-what-should-i-do Since every developer have access to it and it is the same for everyone I didn't set it as a secret.

: (process.env.RECAPTCHA_SITE_KEY as string);

export default function SignInForm({
disabled,
Expand Down
6 changes: 3 additions & 3 deletions verification/curator-service/ui/src/components/landing-page/SignUpForm.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,6 @@ import { sendCustomGtmEvent } from '../util/helperFunctions';
import ReCAPTCHA from 'react-google-recaptcha';
import PasswordStrengthBar from 'react-password-strength-bar';


const useStyles = makeStyles((theme: Theme) => ({
checkboxRoot: {
display: 'block',
Expand Down Expand Up @@ -93,7 +92,9 @@ interface SignUpFormProps {
setRegistrationScreenOn: (active: boolean) => void;
}

const RECAPTCHA_SITE_KEY = process.env.RECAPTCHA_SITE_KEY as string;
const RECAPTCHA_SITE_KEY = window.Cypress
? '6LeIxAcTAAAAAJcZVRqyHh71UMIEGNQ_MXjiZKhI'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same here

: (process.env.RECAPTCHA_SITE_KEY as string);

export default function SignUpForm({
disabled,
Expand Down Expand Up @@ -166,7 +167,6 @@ export default function SignUpForm({
const token =
(await recaptchaRef.current.executeAsync()) as string;
recaptchaRef.current.reset();

dispatch(
signUpWithEmailAndPassword({
email,
Expand Down