Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Captcha bug fixes #2801

Merged
merged 3 commits into from
Sep 19, 2022
Merged

Captcha bug fixes #2801

merged 3 commits into from
Sep 19, 2022

Conversation

OskarKocjan
Copy link
Contributor

@OskarKocjan OskarKocjan commented Sep 7, 2022 •
edited
Loading

Changes:

  • limiters now skip counting attempt when it is successful
  • ReCaptcha badge is now invisible
  • added information below the sign-in/up button that site is using ReCaptcha
  • fixed bug that didn't block the action of a user that failed the ReCaptcha test
  • moved part of code responsible for ReCaptcha from SignIn and SignUp form to LandingPage

@OskarKocjan OskarKocjan self-assigned this Sep 7, 2022
maciej-zarzeczny
maciej-zarzeczny approved these changes Sep 13, 2022
View reviewed changes
Copy link
Contributor

@maciej-zarzeczny maciej-zarzeczny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@abhidg abhidg merged commit c0c2e71 into main Sep 19, 2022
@abhidg abhidg deleted the captcha-bug-fixes branch September 19, 2022 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maciej-zarzeczny maciej-zarzeczny maciej-zarzeczny approved these changes

@abhidg abhidg Awaiting requested review from abhidg

Assignees

@OskarKocjan OskarKocjan

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@OskarKocjan @maciej-zarzeczny @abhidg