Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#2814 sign in email send correctly to users who register without google account #2892

Merged
merged 1 commit into from
Sep 26, 2022

Conversation

OskarKocjan
Copy link
Contributor

The object had an email message with a lowercase key.
Changes:

  • changed the key of an object with an email message to uppercase for correct reference

@OskarKocjan OskarKocjan self-assigned this Sep 21, 2022
@codecov-commenter
Copy link

Codecov Report

Merging #2892 (94a2260) into main (a9b141e) will decrease coverage by 2.49%.
The diff coverage is 28.57%.

@@            Coverage Diff             @@
##             main    #2892      +/-   ##
==========================================
- Coverage   63.01%   60.51%   -2.50%     
==========================================
  Files          18       21       +3     
  Lines        1214     1312      +98     
  Branches      187      198      +11     
==========================================
+ Hits          765      794      +29     
- Misses        449      518      +69     
Impacted Files Coverage Δ
...on/curator-service/api/src/clients/email-client.ts 61.53% <ø> (ø)
...n/curator-service/api/src/util/instance-details.ts 57.14% <ø> (ø)
...ation/curator-service/api/src/util/validate-env.ts 100.00% <ø> (ø)
verification/curator-service/api/src/index.ts 83.68% <11.11%> (-4.95%) ⬇️
...cation/curator-service/api/src/controllers/auth.ts 44.89% <13.04%> (-3.76%) ⬇️
...ervice/api/src/util/single-window-rate-limiters.ts 37.50% <37.50%> (ø)
...r-service/api/src/util/validate-recaptcha-token.ts 37.50% <37.50%> (ø)
...n/curator-service/api/src/model/failed_attempts.ts 53.84% <53.84%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@abhidg abhidg merged commit aa9388c into main Sep 26, 2022
@abhidg abhidg deleted the 2814-blank-email-body-for-new-user-sign-up branch September 26, 2022 10:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants