Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#2812 user cannot sign in too many failed attempts change #2893

Merged
merged 6 commits into from
Sep 29, 2022

Conversation

OskarKocjan
Copy link
Contributor

Changes:

  • removed skipping successful counting attempts on sign-up and reset password email link for single window rate limiters
  • added resetting counting attempts on successful requests for sign-in, reset password with a token, reset the password on the user's profile for single window rate limiters
  • increased number of failed attempts for single window rate limiters

Oskar Kocjan added 3 commits September 21, 2022 07:47
@OskarKocjan OskarKocjan self-assigned this Sep 26, 2022
Copy link
Contributor

@abhidg abhidg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 update the comment before merging

@@ -2,7 +2,7 @@ import rateLimit from 'express-rate-limit';

export const loginLimiter = rateLimit({
windowMs: 60 * 60 * 1000, // 60 minutes
max: 4, // Limit each IP to 4 requests per `window` (here, per 20 minutes)
max: 6, // Limit each IP to 4 requests per `window` (here, per 20 minutes)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

update comment

@abhidg abhidg merged commit 1637675 into main Sep 29, 2022
@abhidg abhidg deleted the 2812-user-cannot-sign-in-too-many-failed-attempts-change branch September 29, 2022 10:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants