Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#2856 - 500 error while filtering fix #2896

Merged
merged 1 commit into from
Oct 4, 2022
Merged

#2856 - 500 error while filtering fix #2896

merged 1 commit into from
Oct 4, 2022

Conversation

maciej-zarzeczny
Copy link
Contributor

Changes

  • Added missing collations to MongoDB queries (without correct collation no indexes were used which made the queries timeout)
  • Added guards for undefined values coming from the DB

@maciej-zarzeczny maciej-zarzeczny self-assigned this Oct 4, 2022
@maciej-zarzeczny maciej-zarzeczny requested review from OskarKocjan, abhidg and jim-sheldon and removed request for OskarKocjan October 4, 2022 09:20
@abhidg
Copy link
Contributor

abhidg commented Oct 4, 2022

LGTM, could you make another PR for the cypress tests? Thanks!

@abhidg abhidg merged commit 47f4911 into main Oct 4, 2022
@abhidg abhidg deleted the 2856-query-fixes branch October 4, 2022 10:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants