2901 fix country export #2903
Merged
2901 fix country export #2903
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
abhidg
commented
Oct 12, 2022
abhidg
commented
- export(country-export): fix typo, output buckets as jsonArray
- export(transform): support ageRange in addition to ageBuckets
To handle the transition from ageRange to ageBuckets, export scripts now support both, with a preference to ageBucket if that field exists. There are three scenarios that are handled: 1. demographics.ageBuckets is present. This is the preferred option and the code sets the minimum and maximum of the buckets present as the age range 2. demographics.ageRange is present and the age window (difference between the maximum and minimum is at least MINIMUM_AGE_WINDOW 3. demographics.ageRange has a age window below MINIMUM_AGE_WINDOW. In this case the code matches it to the nearest age bucket(s).
Add index used by mongoexport in the export-data scripts
abhidg
force-pushed
the
2901-fix-country-export
branch
from
5d513db
to
6146f8a
Compare
jim-sheldon
reviewed
Oct 13, 2022
jim-sheldon
reviewed
Oct 13, 2022
jim-sheldon
reviewed
Oct 13, 2022
|
Made a couple suggestions for cleaner function signatures, LGTM! |
jim-sheldon
approved these changes
Oct 13, 2022
Also changes notify() to use the environment variable PRUNE_UPLOADS_WEBHOOK_URL instead of using a parameter
export scripts should be deployed for both dev and prod. No anticipated divergence is expected between them is expected at this point, so deploying from main makes sense
abhidg
force-pushed
the
2901-fix-country-export
branch
from
6146f8a
to
36554c8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.