Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#2840 - age display bug #2912

Merged
merged 3 commits into from
Oct 18, 2022
Merged

#2840 - age display bug #2912

merged 3 commits into from
Oct 18, 2022

Conversation

maciej-zarzeczny
Copy link
Contributor

Changes

  • Modified age parsing function
  • Fixed other found bug: when user had filters set and refreshed the page there was a race condition on two queries to the DB one with the filters and one without. Because of that sometimes the results were filtered and sometimes not. This is now also fixed

@abhidg
Copy link
Contributor

abhidg commented Oct 18, 2022

@maciej-zarzeczny there is a failing test case, there needs to be a space on either side of the hyphen in the formatting, otherwise 👍

@maciej-zarzeczny
Copy link
Contributor Author

@abhidg Thanks for the review, I've missed that while changing the function. It should be fixed now

@codecov-commenter
Copy link

Codecov Report

Merging #2912 (f10e87a) into main (93e2dc8) will decrease coverage by 3.63%.
The diff coverage is 66.66%.

@@            Coverage Diff             @@
##             main    #2912      +/-   ##
==========================================
- Coverage   60.33%   56.69%   -3.64%     
==========================================
  Files          21      110      +89     
  Lines        1316     3457    +2141     
  Branches      199     1097     +898     
==========================================
+ Hits          794     1960    +1166     
- Misses        522     1497     +975     
Impacted Files Coverage Δ
...on/curator-service/ui/src/components/App/index.tsx 87.39% <0.00%> (ø)
...ui/src/components/LinelistTable/helperFunctions.ts 50.00% <ø> (ø)
...ion/curator-service/ui/src/components/ViewCase.tsx 80.79% <ø> (ø)
...-service/ui/src/components/util/helperFunctions.ts 72.22% <71.42%> (ø)
...-service/ui/src/components/LinelistTable/index.tsx 51.23% <100.00%> (ø)
...r-service/api/src/util/validate-recaptcha-token.ts
verification/curator-service/api/src/model/user.ts
...ation/curator-service/api/src/controllers/cases.ts
...n/curator-service/api/src/model/failed_attempts.ts
...urator-service/api/src/clients/aws-batch-client.ts
... and 126 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@abhidg abhidg merged commit 8b23708 into main Oct 18, 2022
@abhidg abhidg deleted the 2840-undefined-age-bug-fix branch October 18, 2022 22:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants