[115] Update formik datepicker date parsing method to avoid timezone issues #133
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abhidg
reviewed
May 30, 2024
| @@ -210,6 +210,8 @@ const initialValuesFromCase = ( | |||
| }, | |||
| events: { | |||
| ...c.events, | |||
| dateEntry: toLocalDate(c.events.dateEntry), | |||
| dateReported: toLocalDate(c.events.dateReported), | |||
There was a problem hiding this comment.
Is there any reason not to report in UTC everywhere? I can see the value of timezones in data collection, less so for reporting.
There was a problem hiding this comment.
We do store all of the dates in the UTC values, however the component for selecting date on the front-end automatically adjusts date in UTC to local time, thus making the local-date itself. This was an issue as the users in "minus" timezones experienced an issue where they see a date set to a day before.
It can be solved by parsing the UTC date to a local date before by removing the time component (dayjs(dateString.split('T')[0]).toDate()), which will solve the issue with "skipping days" in certain timezones.
stanislaw-zakrzewski
deleted the
115-consider-removal-of-date-auto-populate-function
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partly solves: #115
Formik was parsing date timestamp to local date, which caused issues for some of the timezones. Making sure that no parsing from UTC to local time takes place we fix that issue.