-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#2954 curator api disease agnostic #2
Conversation
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## main #2 +/- ##
=======================================
Coverage ? 64.75%
=======================================
Files ? 167
Lines ? 5641
Branches ? 1434
=======================================
Hits ? 3653
Misses ? 1988
Partials ? 0 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
verification/curator-service/ui/cypress/e2e/components/AppTest.spec.ts
Outdated
Show resolved
Hide resolved
verification/curator-service/ui/cypress/e2e/components/BulkCaseForm.spec.ts
Outdated
Show resolved
Hide resolved
verification/curator-service/ui/cypress/e2e/components/BulkCaseForm.spec.ts
Outdated
Show resolved
Hide resolved
verification/curator-service/ui/cypress/e2e/components/Curator.spec.ts
Outdated
Show resolved
Hide resolved
Great work! I support adding skipped tests back later, as long as they're captured in tickets. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! Wanted to clarify that this is using iSO 3166-1 two letter country codes? Field name could be renamed to ISO2. Alternatively, could use three letter codes everywhere. We used two letter codes in the G.h COVID-19 line list, and three letter codes in mpox; either works.
This PR has changes in both API and UI directories. This is a first version of turnkey curator portal. It utilizes bare minimum day 0 case schema. Because of that some tests or code parts are skipped/commented out. I didn't want to delete them as some tasks that I will create as a follow up will use those code parts.
Changes