Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#2954 curator api disease agnostic #2

Merged
merged 32 commits into from
Mar 14, 2023

Conversation

maciej-zarzeczny
Copy link
Contributor

@maciej-zarzeczny maciej-zarzeczny commented Feb 16, 2023

This PR has changes in both API and UI directories. This is a first version of turnkey curator portal. It utilizes bare minimum day 0 case schema. Because of that some tests or code parts are skipped/commented out. I didn't want to delete them as some tasks that I will create as a follow up will use those code parts.

Changes

  • Implemented Day 0 case schema to UI and API
  • Changed endpoints that handle CRUD cases operations
  • Updated scripts that set up database, indexes and migrations
  • Changed UI components that utilize case schema
  • Updated Cypress and react-testing-library tests as well as API tests

@codecov-commenter
Copy link

codecov-commenter commented Mar 7, 2023

Codecov Report

❗ No coverage uploaded for pull request base (main@144430b). Click here to learn what that means.
The diff coverage is n/a.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@           Coverage Diff           @@
##             main       #2   +/-   ##
=======================================
  Coverage        ?   64.75%           
=======================================
  Files           ?      167           
  Lines           ?     5641           
  Branches        ?     1434           
=======================================
  Hits            ?     3653           
  Misses          ?     1988           
  Partials        ?        0           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@jim-sheldon
Copy link
Contributor

Great work! I support adding skipped tests back later, as long as they're captured in tickets.

Copy link
Contributor

@abhidg abhidg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Wanted to clarify that this is using iSO 3166-1 two letter country codes? Field name could be renamed to ISO2. Alternatively, could use three letter codes everywhere. We used two letter codes in the G.h COVID-19 line list, and three letter codes in mpox; either works.

data-serving/data-service/api/openapi.yaml Outdated Show resolved Hide resolved
@maciej-zarzeczny maciej-zarzeczny merged commit aecc438 into main Mar 14, 2023
@maciej-zarzeczny maciej-zarzeczny deleted the 2954-curator-api-disease-agnostic branch March 14, 2023 09:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants