Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[LIST-2973] shorter case ids #4

Merged
merged 14 commits into from
Apr 6, 2023
Merged

[LIST-2973] shorter case ids #4

merged 14 commits into from
Apr 6, 2023

Conversation

stanislaw-zakrzewski
Copy link
Collaborator

@stanislaw-zakrzewski stanislaw-zakrzewski commented Mar 27, 2023

Solves: LIST-#2973

This PR adds a shorter case ids for cases.

@stanislaw-zakrzewski stanislaw-zakrzewski self-assigned this Mar 27, 2023
@codecov-commenter
Copy link

codecov-commenter commented Mar 31, 2023

Codecov Report

Merging #4 (10b06b5) into main (aecc438) will decrease coverage by 4.66%.
The diff coverage is n/a.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@            Coverage Diff             @@
##             main       #4      +/-   ##
==========================================
- Coverage   64.69%   60.03%   -4.66%     
==========================================
  Files         167      130      -37     
  Lines        5645     4507    -1138     
  Branches     1438     1186     -252     
==========================================
- Hits         3652     2706     -946     
+ Misses       1993     1801     -192     
Impacted Files Coverage Δ
verification/curator-service/api/src/index.ts 83.68% <ø> (ø)

... and 38 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Contributor

@abhidg abhidg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure about the upsert logic, looks good otherwise.

data-serving/data-service/src/index.ts Show resolved Hide resolved
@abhidg abhidg merged commit 690949a into main Apr 6, 2023
@stanislaw-zakrzewski stanislaw-zakrzewski changed the title #2973 shorter case ids [LIST-2973] shorter case ids Oct 4, 2023
@stanislaw-zakrzewski stanislaw-zakrzewski deleted the 2973-shorter-case-ids branch October 4, 2023 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants