Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[LIST-2974] restore latitude and logitude to location object #5

Conversation

stanislaw-zakrzewski
Copy link
Collaborator

@stanislaw-zakrzewski stanislaw-zakrzewski commented Apr 12, 2023

Solves: LIST-#2974

This PR adds back longitude, latitude and geoResolution to location object.

Additionally created some tests to check if geoResolution behaviour is as desired.

@codecov-commenter
Copy link

codecov-commenter commented Apr 12, 2023

Codecov Report

Merging #5 (b86d8a7) into main (690949a) will increase coverage by 1.41%.
The diff coverage is 84.61%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@            Coverage Diff             @@
##             main       #5      +/-   ##
==========================================
+ Coverage   65.02%   66.43%   +1.41%     
==========================================
  Files         165      144      -21     
  Lines        5595     4287    -1308     
  Branches     1429     1235     -194     
==========================================
- Hits         3638     2848     -790     
+ Misses       1957     1439     -518     
Impacted Files Coverage Δ
data-serving/data-service/src/model/location.ts 100.00% <ø> (ø)
...ion/curator-service/ui/src/components/CaseForm.tsx 49.45% <0.00%> (-0.55%) ⬇️
...ion/curator-service/ui/src/components/ViewCase.tsx 71.42% <ø> (ø)
data-serving/data-service/src/controllers/case.ts 78.07% <100.00%> (+0.22%) ⬆️
data-serving/data-service/src/util/case.ts 87.30% <100.00%> (+0.33%) ⬆️
...i/src/components/new-case-form-fields/Location.tsx 100.00% <100.00%> (ø)

... and 22 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Contributor

@abhidg abhidg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

Copy link
Contributor

@jim-sheldon jim-sheldon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@stanislaw-zakrzewski stanislaw-zakrzewski merged commit 4189d6f into main May 5, 2023
@stanislaw-zakrzewski stanislaw-zakrzewski changed the title #2974 restore latitude and logitude to location object [LIST-2974] restore latitude and logitude to location object Oct 4, 2023
@stanislaw-zakrzewski stanislaw-zakrzewski deleted the 2974-restore-latitude-and-logitude-to-location-object branch October 4, 2023 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants