-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[LIST-2974] restore latitude and logitude to location object #5
[LIST-2974] restore latitude and logitude to location object #5
Conversation
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## main #5 +/- ##
==========================================
+ Coverage 65.02% 66.43% +1.41%
==========================================
Files 165 144 -21
Lines 5595 4287 -1308
Branches 1429 1235 -194
==========================================
- Hits 3638 2848 -790
+ Misses 1957 1439 -518
... and 22 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me!
Solves: LIST-#2974
This PR adds back longitude, latitude and geoResolution to location object.
Additionally created some tests to check if geoResolution behaviour is as desired.