Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[LIST-2978] fix download metrics #7

Merged
merged 2 commits into from
May 22, 2023

Conversation

stanislaw-zakrzewski
Copy link
Collaborator

@stanislaw-zakrzewski stanislaw-zakrzewski commented May 11, 2023

Solves: LIST-#2978

@stanislaw-zakrzewski stanislaw-zakrzewski self-assigned this May 11, 2023
@codecov-commenter
Copy link

Codecov Report

Merging #7 (0c4a2a4) into main (4189d6f) will increase coverage by 5.27%.
The diff coverage is 0.00%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@            Coverage Diff             @@
##             main       #7      +/-   ##
==========================================
+ Coverage   66.45%   71.72%   +5.27%     
==========================================
  Files         144       56      -88     
  Lines        4287     2423    -1864     
  Branches     1235      452     -783     
==========================================
- Hits         2849     1738    -1111     
+ Misses       1438      685     -753     
Impacted Files Coverage Δ
...ation/curator-service/api/src/controllers/cases.ts 47.48% <0.00%> (ø)

... and 130 files with indirect coverage changes

@stanislaw-zakrzewski
Copy link
Collaborator Author

I've also fixed yaml typing, which for downloads should not have been changed

Copy link
Contributor

@jim-sheldon jim-sheldon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks for doing this!

@stanislaw-zakrzewski stanislaw-zakrzewski merged commit 5f1057f into main May 22, 2023
@stanislaw-zakrzewski stanislaw-zakrzewski changed the title 2978 fix download metrics [LIST-2978] fix download metrics Oct 4, 2023
@stanislaw-zakrzewski stanislaw-zakrzewski deleted the 2978-fix-downloads-metric branch October 4, 2023 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants