Add support for dotenv. #19
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will allow us to auto-load environment variables configured in .env files, instead of having to load them manbually.
|
For some reason, CircleCI fails on unauthorized when trying to install dotenv. Maybe @KensoDev can help? |
sefininio
commented
Aug 2, 2018
| @@ -0,0 +1,3 @@ | |||
| import dotenv from 'dotenv'; | |||
|
|
|||
| export default dotenv.config({ silent: true }); | |||
There was a problem hiding this comment.
This should run before all other code that might use process.env, hence it is important to export it in the index.js file before all other exports.
For more info, please see here: https://www.npmjs.com/package/dotenv#how-do-i-use-dotenv-with-import- and here: motdotla/dotenv#133 (comment)
|
Commented on the issue in Slack DM. |
|
Please make sure to namespace jfrog, this package should come from npm, not from jfrog. |
KensoDev
suggested changes
Aug 3, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this?
This will allow us to auto-load environment variables configured in .env files,
instead of having to load them manually.
Does this change affect other projects?
This will not require any code changes on gateways, however it will require the .env files to have a slightly different format, namely: instead of
export VAR_NAME=value, dotenv expectsVAR_NAME=value, so this has implications on all gateway code that uses .env files.That said, this will not break if the .env file remains unchanged and we can still use the manual
source .envoption until all gateways are updated.Naming conventions
I am not sure the variables / file names I used comply with the conventions we normally use for nodule* projects, so I'd welcome any alternatives you might suggest.