Skip to content
This repository has been archived by the owner on Oct 2, 2024. It is now read-only.

Update express to 4.17.3 to address querystring vulnerability #66

Merged
merged 2 commits into from
Jan 4, 2023
Merged

Update express to 4.17.3 to address querystring vulnerability #66

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
119d0d1
Update express to 4.17.3 to address querystring vulnerability
eleichter-globality Dec 21, 2022
87f772e
Actually, lets try the caret
eleichter-globality Dec 22, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@
"connect-requestid": "^1.1.0",
"cors": "^2.8.4",
"dataloader": "^1.4.0",
"express": "^4.16.3",
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just want to verify that we want 4.17.3 and not ^4.17.3

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good call, it looks like we can. This gets us express 4.18.2, which has qs 6.11.0 which has the fix (that came from here). And I verified that I can't reproduce the vulnerability with this new version of nodule-express + express.

(I'm somewhat obsessively double-checking all this because I spent the better part of the day jumping through dependency hell to test this).

"express": "^4.17.3",
"helmet": "^3.12.0",
"http-status-codes": "^1.3.0",
"jsonwebtoken": "^8.2.0",
Expand Down
Loading