Skip to content

Commit

Permalink
refactor: prevent duplicate selection of addresses in CreateOfficerTe…
Browse files Browse the repository at this point in the history
…am.vue
  • Loading branch information
dasarathg68 committed Oct 10, 2024
1 parent cbab501 commit 4f40b7f
Showing 1 changed file with 16 additions and 1 deletion.
17 changes: 16 additions & 1 deletion app/src/components/forms/CreateOfficerTeam.vue
Original file line number Diff line number Diff line change
Expand Up @@ -155,13 +155,28 @@ const createTeam = async () => {
}
const selectFounder = (user: { name: string; address: string }) => {
const lowerAddress = user.address.toLowerCase()

Check warning on line 158 in app/src/components/forms/CreateOfficerTeam.vue

View check run for this annotation

Codecov / codecov/patch

app/src/components/forms/CreateOfficerTeam.vue#L158

Added line #L158 was not covered by tests
if (
selectedFounders.value.some((f) => f.address.toLowerCase() === lowerAddress) ||
selectedMembers.value.some((m) => m.address.toLowerCase() === lowerAddress)

Check warning on line 161 in app/src/components/forms/CreateOfficerTeam.vue

View check run for this annotation

Codecov / codecov/patch

app/src/components/forms/CreateOfficerTeam.vue#L161

Added line #L161 was not covered by tests
) {
addErrorToast('This address is already selected')
return

Check warning on line 164 in app/src/components/forms/CreateOfficerTeam.vue

View check run for this annotation

Codecov / codecov/patch

app/src/components/forms/CreateOfficerTeam.vue#L163-L164

Added lines #L163 - L164 were not covered by tests
}
const lastIndex = selectedFounders.value.length - 1
selectedFounders.value[lastIndex].name = user.name
selectedFounders.value[lastIndex].address = user.address
showFounderDropdown.value = false
}
const selectMember = (user: { name: string; address: string }) => {
const lowerAddress = user.address.toLowerCase()

Check warning on line 172 in app/src/components/forms/CreateOfficerTeam.vue

View check run for this annotation

Codecov / codecov/patch

app/src/components/forms/CreateOfficerTeam.vue#L172

Added line #L172 was not covered by tests
if (
selectedFounders.value.some((f) => f.address.toLowerCase() === lowerAddress) ||
selectedMembers.value.some((m) => m.address.toLowerCase() === lowerAddress)

Check warning on line 175 in app/src/components/forms/CreateOfficerTeam.vue

View check run for this annotation

Codecov / codecov/patch

app/src/components/forms/CreateOfficerTeam.vue#L175

Added line #L175 was not covered by tests
) {
addErrorToast('This address is already selected')
return

Check warning on line 178 in app/src/components/forms/CreateOfficerTeam.vue

View check run for this annotation

Codecov / codecov/patch

app/src/components/forms/CreateOfficerTeam.vue#L177-L178

Added lines #L177 - L178 were not covered by tests
}
const lastIndex = selectedMembers.value.length - 1
selectedMembers.value[lastIndex].name = user.name
selectedMembers.value[lastIndex].address = user.address
Expand Down

0 comments on commit 4f40b7f

Please sign in to comment.