Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/heroicon vue #255

Merged
merged 19 commits into from
Jul 8, 2024
Merged

Feature/heroicon vue #255

merged 19 commits into from
Jul 8, 2024

Conversation

hermannleboss
Copy link
Contributor

@hermannleboss hermannleboss commented Jul 8, 2024

Description

Use of Hero Icon to avoid the usage of custom SVG component
Fixes #242

Type of change

Refactoring

Acceptance Criteria

  • Installed HeroIcons Vue
  • Refactor icon to use HeroIcons

Copy link
Contributor

@dasarathg68 dasarathg68 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add Member plus icon color seems to be wrong
image

Copy link
Contributor

@dasarathg68 dasarathg68 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Colour seems to be missing in the icons?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why is the class text-green? we dont have any text there
it should be bg-green-700 right?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TO change icon color you use colors in css what is text-[color]

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will skip the colors for the icons in the PR.

We will focus on them later.

Copy link

codecov bot commented Jul 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 36.84%. Comparing base (9b7313c) to head (412ddac).
Report is 5 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #255      +/-   ##
===========================================
- Coverage    36.85%   36.84%   -0.02%     
===========================================
  Files           86       81       -5     
  Lines         1430     1425       -5     
  Branches       327      327              
===========================================
- Hits           527      525       -2     
+ Misses         781      779       -2     
+ Partials       122      121       -1     
Flag Coverage Δ
app-unit-tests 36.84% <100.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hermannleboss hermannleboss merged commit 4c8bf0a into develop Jul 8, 2024
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Features] Use of Heroicons vue to uniform the icone interfaces.
2 participants