Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/permissioning system #305

Open
wants to merge 51 commits into
base: develop
Choose a base branch
from

Conversation

hermannleboss
Copy link
Contributor

Description

WIP permissioning system

Fixes # (issue)

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • Please check if the PR fulfills these requirements
  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes/features)
  • Docs have been added / updated (for bug fixes / features)

aliassan and others added 30 commits July 3, 2024 19:13
Add parameters for the value of each entitlement type.
Merge branch 'develop' into feature/permissioning-system
…system

Merge "feature/permissioning-system" in "feat/PS/backend"
Co-authored-by: Dasarath G <31665486+dasarathg68@users.noreply.github.com>
@hermannleboss hermannleboss marked this pull request as draft August 17, 2024 11:24
Copy link

codecov bot commented Aug 17, 2024

Codecov Report

Attention: Patch coverage is 18.91892% with 120 lines in your changes missing coverage. Please review.

Project coverage is 65.20%. Comparing base (fd279aa) to head (b8619be).
Report is 1 commits behind head on develop.

Files with missing lines Patch % Lines
...end/src/controllers/role/roleCategoryController.ts 9.43% 45 Missing and 3 partials ⚠️
backend/src/utils/roleUtil.ts 8.57% 25 Missing and 7 partials ⚠️
backend/src/controllers/role/roleController.ts 8.82% 29 Missing and 2 partials ⚠️
.../src/controllers/role/entitlementTypeController.ts 18.18% 8 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #305      +/-   ##
===========================================
- Coverage    67.76%   65.20%   -2.57%     
===========================================
  Files          128      132       +4     
  Lines         4362     4403      +41     
  Branches      1107     1102       -5     
===========================================
- Hits          2956     2871      -85     
- Misses        1134     1253     +119     
- Partials       272      279       +7     
Flag Coverage Δ
api-unit-tests 27.65% <18.91%> (-3.25%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hermannleboss hermannleboss marked this pull request as ready for review August 17, 2024 11:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants