Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/ps/assign user roles backend #311

Open
wants to merge 16 commits into
base: feature/permissioning-system
Choose a base branch
from

Conversation

aliassan
Copy link
Contributor

Description

Assign user roles back-end implementation.

Fixes # (issue)

Type of change

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • Please check if the PR fulfills these requirements
  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes/features)
  • Docs have been added / updated (for bug fixes / features)

Copy link
Contributor

@dasarathg68 dasarathg68 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

codecov bot commented Oct 10, 2024

Codecov Report

Attention: Patch coverage is 19.08397% with 106 lines in your changes missing coverage. Please review.

Project coverage is 59.72%. Comparing base (b8619be) to head (6130d69).

Files with missing lines Patch % Lines
backend/src/controllers/teamController.ts 7.31% 33 Missing and 5 partials ⚠️
...ctions/SingleTeamView/forms/AddMemberRolesForm.vue 0.00% 13 Missing and 6 partials ⚠️
app/src/components/NotificationDropdown.vue 35.71% 16 Missing and 2 partials ⚠️
...src/components/forms/roles/AddRoleCategoryForm.vue 0.00% 7 Missing and 1 partial ⚠️
...mponents/sections/SingleTeamView/MemberSection.vue 27.27% 8 Missing ⚠️
app/src/components/forms/roles/AddRoleForm.vue 0.00% 4 Missing and 1 partial ⚠️
app/src/utils/generalUtil.ts 16.66% 4 Missing and 1 partial ⚠️
.../src/components/forms/roles/AddEntitlementForm.vue 0.00% 1 Missing and 1 partial ⚠️
.../components/sections/role-categories/RoleTable.vue 0.00% 2 Missing ⚠️
app/src/views/RoleCategoryView.vue 0.00% 1 Missing ⚠️
Additional details and impacted files
@@                       Coverage Diff                        @@
##           feature/permissioning-system     #311      +/-   ##
================================================================
- Coverage                         65.20%   59.72%   -5.48%     
================================================================
  Files                               132      154      +22     
  Lines                              4403     5140     +737     
  Branches                           1102     1304     +202     
================================================================
+ Hits                               2871     3070     +199     
- Misses                             1253     1704     +451     
- Partials                            279      366      +87     
Flag Coverage Δ
api-unit-tests 26.61% <13.63%> (-1.05%) ⬇️
app-unit-tests 61.04% <21.83%> (-6.57%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants