-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: prevent duplicate selection #390
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## release/v0.2 #390 +/- ##
===============================================
Coverage ? 66.36%
===============================================
Files ? 125
Lines ? 4305
Branches ? 1099
===============================================
Hits ? 2857
Misses ? 1172
Partials ? 276
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Prevent the duplicate selection of founders and members in the CreateOfficerForm component.
When there is a value in the name input, and i'm updating the address input it's searching a mach for both. expected behaviour: I have 2 user Hermann 0x123 if i have in the input of name Da Normaly the result of the search should be the latest update. That mean if i'm typing 0x1... i should have address search |
@hermannleboss |
OK |
Description
Prevent duplicate selection of founders and members in the CreateOfficerTeam form.
Contribution
For your PR please add a commnent to eache file edited to explain the changes you made.
Type of change
Please delete options that are not relevant.
Checklist
Make sur you run the following commands before submitting your PR:
npm run build npm run test npm run lint npm run format
npm run test npm run lint npm run format
Please check if the PR fulfills these requirements
The commit message follows our guidelines