Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: prevent duplicate selection #390

Merged
merged 4 commits into from
Oct 10, 2024

Conversation

dasarathg68
Copy link
Contributor

Description

Prevent duplicate selection of founders and members in the CreateOfficerTeam form.

Contribution

For your PR please add a commnent to eache file edited to explain the changes you made.

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

Checklist

Make sur you run the following commands before submitting your PR:

  • /app
npm run build
npm run test:unit
npm run type-check
npm run lint
npm run format
  • /backend
npm run build
npm run test
npm run lint
npm run format
  • /contract
npm run test
npm run lint
npm run format
  • Please check if the PR fulfills these requirements

  • The commit message follows our guidelines

@dasarathg68 dasarathg68 self-assigned this Oct 10, 2024
@dasarathg68 dasarathg68 changed the base branch from develop to release/v0.2 October 10, 2024 08:47
Copy link

codecov bot commented Oct 10, 2024

Codecov Report

Attention: Patch coverage is 0% with 12 lines in your changes missing coverage. Please review.

Please upload report for BASE (release/v0.2@cbab501). Learn more about missing BASE report.

Files with missing lines Patch % Lines
app/src/components/forms/CreateOfficerTeam.vue 0.00% 8 Missing and 4 partials ⚠️
Additional details and impacted files
@@               Coverage Diff               @@
##             release/v0.2     #390   +/-   ##
===============================================
  Coverage                ?   66.36%           
===============================================
  Files                   ?      125           
  Lines                   ?     4305           
  Branches                ?     1099           
===============================================
  Hits                    ?     2857           
  Misses                  ?     1172           
  Partials                ?      276           
Flag Coverage Δ
app-unit-tests 67.05% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Prevent the duplicate selection of founders and members in the CreateOfficerForm component.

@dasarathg68 dasarathg68 marked this pull request as ready for review October 10, 2024 08:48
@hermannleboss
Copy link
Contributor

When there is a value in the name input, and i'm updating the address input it's searching a mach for both.

expected behaviour:

I have 2 user

Hermann 0x123
Dasarath 0xABC

if i have in the input of name Da
and in the input of address 0x

Normaly the result of the search should be the latest update.

That mean if i'm typing 0x1... i should have address search
and if i'm typing Da.. i should have name search.

image

@hermannleboss
Copy link
Contributor

Second if i click outside of an input the search result should not be visible.

image

@dasarathg68
Copy link
Contributor Author

@hermannleboss
The two suggestions are beyond the scope of this PR, I will create issues for them and address them separately.

@hermannleboss
Copy link
Contributor

@hermannleboss The two suggestions are beyond the scope of this PR, I will create issues for them and address them separately.

OK

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants