typescriptとeslintまわりのpackage.jsonを書き換え #289
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
circle ciのnodeのversionが古かったので上げました。 |
|
Secrets Scan with Trivyはこのプルリクでは対応せず、別途プルリクを出します。 |
TokiyaHorikawa
approved these changes
Dec 27, 2023
| - image: circleci/node:lts-browsers | ||
| - image: cimg/node:18.18.1-browsers |
There was a problem hiding this comment.
circleci imageは古いからcimgにする
cimg/nodeのltsは20.10.0のエイリアスになる。
LTSに追従したい気持ちはあるが、一旦18明示していでもいいかもねという感想
https://circleci.com/developer/images/image/cimg/node
Comment on lines
30
to
32
| "eslint": "^6.7.2 || ^7.0.0 || ^8.0.0", | ||
| "prettier": "^1.19.1 || ^2.0.0", | ||
| "typescript": "^3.7.4 || ^4.0.0" | ||
| "typescript": "^3.7.4 || ^4.0.0 || ^5.0.0" |
There was a problem hiding this comment.
古いバージョンは捨てていきたい気持ち
（別PRでやろう！）
nabeen
requested changes
Dec 27, 2023
|
手元で試してみてという話をした |
nabeen
approved these changes
Dec 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://github.com/globis-org/frontend-standard/pulls
を参考にtypescriptとeslintまわりのpackage.jsonを書き換えました。
テストは
yarn workspaces run testを実行したのみですが、ほかにできることがあれば教えてください。