Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert PMFT to use nanobind #1270

Closed
wants to merge 13 commits into from
Closed

Convert PMFT to use nanobind #1270

wants to merge 13 commits into from

Conversation

tommy-waltmann
Copy link
Collaborator

Description

This PR converts the PMFT module to use nanobind.

Motivation and Context

This PR is part of a series of PRs which removes the cython from freud.

How Has This Been Tested?

If existing tests pass, this PR should be good to go.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds or improves functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation improvement (updates to user guides, docstrings, or developer docs)

Checklist:

  • I have read the CONTRIBUTING document.
  • My code follows the code style of this project.
  • I have updated the documentation (if relevant).
  • I have added tests that cover my changes (if relevant).
  • All new and existing tests passed.
  • I have updated the credits.
  • I have updated the Changelog.

@joaander joaander closed this Aug 27, 2024
@joaander joaander deleted the pybind11-pmft branch August 27, 2024 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants