Mesh bending rigidity potential #1792
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…/hoomd-blue into mesh_bending_rigidity
…/hoomd-blue into mesh_bending_rigidity
SchoeniPhlippsn
requested review from
a team and
joaander
and removed request for
a team
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. |
github-actions
bot
added
the
stale
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. |
github-actions
bot
added
the
stale
joaander
requested changes
Jul 26, 2024
There was a problem hiding this comment.
Thanks! I've made some suggestions to clean up the code.
As @tommy-waltmann said, you also need to make some modifications to the documentation will appear in the sphinx generated docs.
added 12 commits
July 28, 2024 18:58
|
pre-commit.ci autofix |
for more information, see https://pre-commit.ci
joaander
approved these changes
Aug 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This adds a bending rigidity potential which can be applied to the mesh data structure.
Motivation and context
This generalized bending rigidity allows for applying different bending moduli to a membrane which is represented by a particle mesh.
How has this been tested?
I added pytests and used this potential in my current studies.
Change log
Checklist:
sphinx-doc/credits.rst) in the pull request source branch.