Fix MPCD compiler warning #1845
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mphoward
requested review from
a team,
joaander,
SchoeniPhlippsn and
seoulfood
and removed request for
a team
joaander
approved these changes
Jul 17, 2024
joaander
added
the
validate
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The compiler warning was being generated because of the use of
GammaDistributioninkernel::srd_draw_vectors. This PR rearranges that function to remove the use of recursion.Motivation and context
Code should compile without warnings.
Resolves #1844
How has this been tested?
Existing unit tests pass, and the compiler warning is gone.
Change log
Checklist:
sphinx-doc/credits.rst) in the pull request source branch.