Add _ext_module variable to base python classes #1853
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Without the variable
_ext_module
some of the base python classes cannot be easily extended in external plugins, because it will not correctly find it, i.e when wanting to use or import "plugin_name.wall.PotentialName" it will instead look for "hoomd.wall.PotentialName". The simple inclusion of "_ext_module = _md" that can be overwritten by the plugin fixes this issue.Motivation and context
Needed for convenient development of external plugins.
Resolves Issue #1852.
How has this been tested?
This has been tested locally on the CPU. Because it only touches *.py files, no other tests are necessary.
Change log
Checklist:
sphinx-doc/credits.rst
) in the pull request source branch.