Make the link checking CI more robost #1906
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This should be less prone to false postivie errors. Also allow the use of lychee locally on the command line.
joaander
force-pushed
the
robust-lychee
branch
from
61752ad
to
aefbfc2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Many sites block GitHub actions servers and/or bots from accessing them. This new lychee configuration allow tests to pass even when the bot gets a 500 internal server error or access denied.
Motivation and context
Even with the error, the fact that it is not a 404 means the link is likely still valid.
How has this been tested?
CI checks and local execution of lychee.
Change log
No log entry necessary.
Checklist:
sphinx-doc/credits.rst) in the pull request source branch.