Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix updating of image viewer when data is modified #339

Merged
merged 1 commit into from
Feb 3, 2023

Conversation

astrofrog
Copy link
Member

Similar to glue-viz/glue#2344

@codecov
Copy link

codecov bot commented Jan 3, 2023

Codecov Report

Base: 89.50% // Head: 89.52% // Increases project coverage by +0.01% 🎉

Coverage data is based on head (5fab31f) compared to base (76eb469).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #339      +/-   ##
==========================================
+ Coverage   89.50%   89.52%   +0.01%     
==========================================
  Files          86       86              
  Lines        4365     4371       +6     
==========================================
+ Hits         3907     3913       +6     
  Misses        458      458              
Impacted Files Coverage Δ
glue_jupyter/bqplot/image/viewer.py 87.32% <100.00%> (+1.17%) ⬆️
glue_jupyter/utils.py 64.21% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@astrofrog astrofrog force-pushed the misc-fixes-reprojection branch from 19417e4 to 5fab31f Compare February 3, 2023 09:51
@astrofrog astrofrog marked this pull request as ready for review February 3, 2023 09:51
@astrofrog astrofrog merged commit 8a32f2e into glue-viz:main Feb 3, 2023
@astrofrog astrofrog changed the title Fix issues that came up while testing on-the-fly reprojection Fix updating of image viewer when data is modified Feb 3, 2023
@astrofrog astrofrog added the bug Something isn't working label Feb 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant