Issue 599 #606
Merged
Issue 599 #606
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Marwes
commented
Aug 7, 2018
| @@ -1177,7 +1189,7 @@ impl<'a, 'e> Unifier<State<'a>, ArcType> for UnifierState<'a, Subsume<'e>> { | |||
| } | |||
|
|
|||
| (_, &Type::Forall(_, _, Some(_))) => { | |||
| let r = r.instantiate_generics(&mut FnvMap::default()); | |||
There was a problem hiding this comment.
This was the actual unsound line. Unfortunately fixing this (and the direct fallout) exposed a unfication ambiguity where I have two sound programs but only one or the other will successfully typecheck depending on some minor tweaks to the typechecker... Researching options for now.
There was a problem hiding this comment.
See the unify_with_inferred_forall_in_record test https://github.com/gluon-lang/gluon/pull/606/files#diff-697e0a05f79902051453dccb6fd941c2R1050
Adds error types and kinds which always succeeds unification by always returning that they are the other parameter. Since these can only be created from an error that occurred earlier this does not cause unsoundness and ensures that errors that actually are more local (since they disregard erroneous info from other failed unifications).
Fixed in previous higher ranked fixes. Closes gluon-lang#604
This makes it consistent with the implicit arguments inserted during function application. Fixes gluon-lang#601
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #599