Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(vm): Automatically remove the elements added to pushed data #720

Merged
merged 1 commit into from
Apr 27, 2019
Merged

fix(vm): Automatically remove the elements added to pushed data #720

merged 1 commit into from
Apr 27, 2019

Conversation

Marwes
Copy link
Member

@Marwes Marwes commented Apr 27, 2019

The generated code accounted for this but by moving it in we get a
simpler interface.

Fixes #719

@Marwes
fix(vm): Automatically remove the elements added to pushed data
8cd5152 
The generated code accounted for this but by moving it in we get a
simpler interface.

Fixes gluon-lang#719
@Marwes Marwes mentioned this pull request Apr 27, 2019
Closed
@Marwes
Copy link
Member Author

Marwes commented Apr 27, 2019

bors r+

bors bot added a commit that referenced this pull request Apr 27, 2019
@bors @Marwes
Merge #720
e27d7b0 
720: fix(vm): Automatically remove the elements added to pushed data r=Marwes a=Marwes

The generated code accounted for this but by moving it in we get a
simpler interface.

Fixes #719

Co-authored-by: Markus Westerlind <marwes91@gmail.com>
@bors
Copy link
Contributor

bors bot commented Apr 27, 2019

Build succeeded

@bors bors bot merged commit 8cd5152 into gluon-lang:master Apr 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Question about proper way to marshal multi-parameter type constructors
1 participant
@Marwes