Add support for textDocument/diagnostic, workspace/diagnostic (3.17) #258
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the process, we also make the `url_map` serializer/deserializer generic over the `HashMap` value so we can reuse it in this request.
ebkalderon
changed the title
This was referenced Feb 28, 2023
|
@Marwes sorry for the ping, can you please take a look? This is an unfortunate omission in the 3.17 support. Thanks a lot for all your work on lsp-types! |
|
Looks good! Released as 0.94.1. |
This was referenced Aug 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added
textDocument/diagnosticrequest (link).workspace/diagnosticrequest (link).workspace/diagnostic/refreshrequest (link).Changed
url_map()to be generic over theHashMapvalue type, making this code reusable intextDocument/diagnostic.diagnosticfield toWorkspaceClientCapabilitiesstruct.diagnosticfield toTextDocumentClientCapabilitiesstruct.diagnostic_providerfield toServerCapabilitiesstruct.It turns out these new 3.17.0 requests were unfortunately missed in PR #255.