Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Icon and title of the OpenJFX Platform binary wrapper #298

Open
jan-tosovsky-cz opened this issue Feb 9, 2021 · 4 comments
Open

Icon and title of the OpenJFX Platform binary wrapper #298

jan-tosovsky-cz opened this issue Feb 9, 2021 · 4 comments
Assignees

Comments

@jan-tosovsky-cz
Copy link

When native image app is running in Windows, it is shown as a child of the OpenJFX Platform binary wrapper in the Windows Taskbar:
image

It would be nice to have both icon and title customizable. That icon (or icons) could be ideally reused from the stage icons.

@jan-tosovsky-cz
Copy link
Author

I can set both icon and label in Resource Hacker tool afterwards, but it would be more convenient to have it specified as a plugin option and applied when generating final exe.

@freya022
Copy link

You can actually automate this on Windows by compiling a resource script using rc.exe and using cvtres.exe to convert the output file into an linkable object, you then only have to link the .obj file by passing it as an argument on the link step

You might have a link warning related to glass.lib but that's okay i believe

To do that you have to fork this plugin and modify it as to accept linker arguments (it's almost the same as how they accept compiler arguments), maybe I would try to open a pull request for it but after seeing the legal conditions to become a contributor, i won't do it.

This way of having an icon (or even more metadata for the executable) seems hacky though so I don't really this is the way of doing such thing

@rladstaetter
Copy link

Is it planned to add a configuration option to gluonfx-maven-plugin to define an app icon? Love to see related activity on this issue. It would be great if one could set meta data like 'productversion', 'file version' etc. as well 👍

@jperedadnr
Copy link
Contributor

Yes, see gluonhq/substrate#1089

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants