Add Icon to Windows native binary #1090
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jperedadnr
reviewed
Jan 18, 2022
| super.link(); | ||
| clearExplorerCache(); | ||
| } catch (IOException ioe) { | ||
| ioe.printStackTrace(); |
There was a problem hiding this comment.
We typically don't print stack traces from here, use Logger.logSevere() instead. You can use logFatal() too, but that will throw a RTE. But since link already propagates an IOE, I'd remove the try-catch, and add a check to super.link(). If it fails, return false. Else continue with the cache.
| } else { | ||
| FileOps.copyResource("/native/windows/assets/icon.ico", iconDir.resolve("icon.ico")); | ||
| Logger.logInfo("Default icon.ico image used. " + | ||
| "Consider adding a custom icon to '/native/windows/assets'."); |
There was a problem hiding this comment.
you mean src/windows/assets?
| // Copy icon.ico to gvm/tmp/icon | ||
| if (Files.exists(userAssets) && Files.isDirectory(userAssets) && Files.exists(userAssets.resolve("icon.ico"))) { | ||
| FileOps.copyFile(userAssets.resolve("icon.ico"), iconDir.resolve("icon.ico")) ; | ||
| Logger.logInfo("User provided icon.ico image used as application icon."); |
| FileOps.copyFile(userAssets.resolve("icon.ico"), iconDir.resolve("icon.ico")) ; | ||
| Logger.logInfo("User provided icon.ico image used as application icon."); | ||
| } else { | ||
| FileOps.copyResource("/native/windows/assets/icon.ico", iconDir.resolve("icon.ico")); |
There was a problem hiding this comment.
You need to add it to gensrc first, then copy it to tmp/icon
| @@ -0,0 +1,3 @@ | |||
| LANGUAGE 0x00, 0x00 | |||
|
|
|||
| 1 ICON "icon.ico" | |||
src/main/java/com/gluonhq/substrate/target/WindowsTargetConfiguration.java
Outdated
Show resolved
Hide resolved
jperedadnr
reviewed
Jan 19, 2022
| Files.createDirectories(windowsAssetPath); | ||
| FileOps.copyResource("/native/windows/assets/icon.ico", windowsAssetPath.resolve("icon.ico")); | ||
| FileOps.copyFile(windowsAssetPath.resolve("icon.ico"), tmpIconDir.resolve("icon.ico")); | ||
| Logger.logInfo("Default icon.ico image used. " + |
There was a problem hiding this comment.
The standard message is:
Logger.logInfo("Default icon.ico image generated in " + windowsAssetPath + ".\n" +
"Consider copying it to " + rootPath + " before performing any modification");
jperedadnr
approved these changes
Jan 19, 2022
|
How should it be used? Creating a gluonfx app, where should custom icons be placed? |
|
If it helps someone: (according westinyang's question) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Taking inspiration from @freya022's comment, I have been able to add an icon to the native exe by linking an icon object.
To create the icon object, we have a static file. Use
rc.execommand to compile the resource file and thencvtres.exeto convert the output file into an linkable object.Issue
Fixes #1086
Progress