-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Osm license #52
base: master
Are you sure you want to change the base?
Osm license #52
Changes from all commits
0899898
a411ebd
a05df7d
f6c7127
7b25538
b66d923
ee68d3a
347599a
ee59b35
417e9c9
5a01dc3
17398a9
9d1c40d
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
This file was deleted.
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -37,4 +37,5 @@ | |
|
||
exports com.gluonhq.maps; | ||
exports com.gluonhq.maps.tile; | ||
exports com.gluonhq.impl.maps.tile.osm; | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. if we are going to export this package, it shouldn't be under There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Please see the original comment: "...Instead of moving CachedOsmTileRetriever around I just modified module-info.java ..." There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I had a look at it but I don't see a simple way to split the CachedOsmTileRetriever between impl and exported packaged, so I prefer not to make any changes for that in the PR. |
||
} |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,4 @@ | ||
.label-license { | ||
-fx-background-color: rgba(126, 126, 126, 0.5); | ||
-fx-font-size: 0.9em; | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For the sake of compatibility, we could keep the no-args constructor, and default to a possible implementation of
CachedOsmTileRetriever
(see comment below)?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thinking about it... I would prefer to not have a no-args constructor actually, for the reasons in comment above.